Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State machine prover #845

Merged
merged 1 commit into from
Sep 26, 2024
Merged

State machine prover #845

merged 1 commit into from
Sep 26, 2024

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Sep 19, 2024 •
edited by hkrasniker-starkware
Loading

This change is Reviewable

This was referenced Sep 19, 2024
Merged
Merged
Merged
Merged
@shaharsamocha7 Graphite App
Copy link
Collaborator Author

shaharsamocha7 commented Sep 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite Graphite

@shaharsamocha7 shaharsamocha7 mentioned this pull request Sep 19, 2024
Merged
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (d7c7997) to head (2074640).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #845      +/-   ##
==========================================
+ Coverage   91.91%   91.99%   +0.08%     
==========================================
  Files          90       90              
  Lines       12375    12375              
  Branches    12375    12375              
==========================================
+ Hits        11374    11384      +10     
+ Misses        892      883       -9     
+ Partials      109      108       -1
Flag Coverage Δ
91.99% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaharsamocha7 shaharsamocha7 force-pushed the 09-19-State_machine_prover branch 2 times, most recently from cce5da9 to c8b4ff7 Compare September 19, 2024 14:13
@shaharsamocha7 shaharsamocha7 marked this pull request as ready for review September 22, 2024 10:37
Alon-Ti
Alon-Ti approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 shaharsamocha7 force-pushed the 09-18-State_machine_AIR branch 2 times, most recently from 7acbcd9 to f86b74a Compare September 24, 2024 14:28
@shaharsamocha7 shaharsamocha7 force-pushed the 09-18-State_machine_AIR branch 2 times, most recently from bfa4e93 to b63647d Compare September 25, 2024 07:05
@shaharsamocha7 shaharsamocha7 mentioned this pull request Sep 26, 2024
Merged
@shaharsamocha7 shaharsamocha7 force-pushed the 09-19-State_machine_prover branch 2 times, most recently from b788bf7 to 7c5d309 Compare September 26, 2024 09:39
Alon-Ti
Alon-Ti approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@shaharsamocha7 Graphite App
Copy link
Collaborator Author

shaharsamocha7 commented Sep 26, 2024 •
edited
Loading

Merge activity

@shaharsamocha7 shaharsamocha7 changed the base branch from 09-18-State_machine_AIR to graphite-base/845 September 26, 2024 14:27
@shaharsamocha7 shaharsamocha7 changed the base branch from graphite-base/845 to dev September 26, 2024 14:28
@shaharsamocha7 shaharsamocha7 merged commit 443ae49 into dev Sep 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alon-Ti Alon-Ti Alon-Ti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaharsamocha7 @codecov-commenter @Alon-Ti